retrieve dynamic search for query request #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 16, 2023
shubham1g5
reviewed
Oct 24, 2023
| @@ -62,6 +62,8 @@ public class QueryScreen extends Screen { | |||
|
|
|||
| private boolean defaultSearch; | |||
|
|
|||
| private boolean dynamicSearch; | |||
There was a problem hiding this comment.
How does this get set for QueryScreen ?
There was a problem hiding this comment.
resolved 8bfbc6f
shubham1g5
reviewed
Nov 7, 2023
| @@ -102,7 +108,7 @@ public void readExternal(DataInputStream in, PrototypeFactory pf) | |||
| description = (Text) ExtUtil.read(in, new ExtWrapNullable(Text.class), pf); | |||
| useCaseTemplate = ExtUtil.readBool(in); | |||
| defaultSearch = ExtUtil.readBool(in); | |||
|
|
|||
| dynamicSearch = ExtUtil.readBool(in); | |||
There was a problem hiding this comment.
you need to add the corresponding write in writeExternal as well
shubham1g5
approved these changes
Nov 8, 2023
| @@ -81,6 +83,10 @@ public boolean doDefaultSearch() { | |||
| return defaultSearch; | |||
| } | |||
|
|
|||
| public boolean getDynamicSearch() { | |||
There was a problem hiding this comment.
nit: rename boolean getters in this PR to is{Var} to signify it's a boolean
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Core element of this ticket: here
formplayer ticket here
HQ Part one here and Part 2 here
will update ref shortly
Technical Summary
see this ticket
Safety Assurance
Safety story
No logic change on formplayer, just sends back the variable if a QueryResponse
Automated test coverage
I will add test shortly
QA Plan
I am not requesting QA
Special deploy instructions
Rollback instructions
there is a formplayer PR as well linked above
Review
Duplicate PR
Automatically duplicate this PR as defined in contributing.md.