Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backward compatibility for Stack Query Datum #1334

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

shubham1g5
Copy link
Contributor

@shubham1g5 shubham1g5 commented Sep 14, 2023

Technical Summary

Jira

Sentry

We added a new model for stack query data in this PR but we need to retain the processing over old model to support existing app serialised states which will have quer data in the old model until app DBs gets refreshed on FP.

Safety Assurance

Retains old code for stack query datum processing which should already have been working.

Safety story

Automated test coverage

Ran the FP side tests again that tests for stack query evaluation.

Special deploy instructions

  • This PR can be deployed after merge with no further considerations.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

Duplicate PR

Automatically duplicate this PR as defined in contributing.md.

@shubham1g5 shubham1g5 merged commit d37dabb into formplayer Sep 14, 2023
2 checks passed
@shubham1g5 shubham1g5 deleted the queryDataFix branch September 14, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants