Check for None value #443
Merged
Check for None value #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemant10yadav
approved these changes
Nov 29, 2024
| @@ -262,7 +262,8 @@ def process_deliver_unit(user, xform: XForm, app: CommCareApp, opportunity: Oppo | |||
| ) | |||
| completed_work_needs_save = False | |||
| today = datetime.date.today() | |||
| if opportunity.start_date > today or (payment_unit.start_date and payment_unit.start_date > today): | |||
| paymentunit_startdate = payment_unit.start_date if payment_unit else None | |||
| if opportunity.start_date > today or (paymentunit_startdate and paymentunit_startdate > today): | |||
There was a problem hiding this comment.
The issue arises when payment_unit is null. In cases where payment_unit is null and opportunity.start_date > today evaluates to false, the code proceeds to the else block. However, since payment_unit is required for completed_work, this results in an error.
There was a problem hiding this comment.
You are right, this seems to be a seperate issue for a while https://dimagi.sentry.io/issues/6098769063/?environment=production&project=4505635339829248&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&sort=date&statsPeriod=14d&stream_index=0
But let’s merge at least this fix, because that affects even where paymentunit is not NULL
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix https://dimagi.sentry.io/issues/6098769063/?project=4505635339829248&referrer=slack introduced here