Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User profile changes #439

Merged
merged 5 commits into from
Nov 21, 2024
Merged

User profile changes #439

merged 5 commits into from
Nov 21, 2024

Conversation

hemant10yadav
Copy link
Contributor

@hemant10yadav hemant10yadav commented Nov 21, 2024 •
edited
Loading

@hemant10yadav hemant10yadav marked this pull request as draft November 21, 2024 04:39
@hemant10yadav hemant10yadav self-assigned this Nov 21, 2024
@hemant10yadav hemant10yadav marked this pull request as ready for review November 21, 2024 08:04
sravfeyn
sravfeyn reviewed Nov 21, 2024
View reviewed changes
commcare_connect/templates/opportunity/user_profile.html Outdated
<span>Active</span>

<!-- Map Section -->
<div class="position-relative">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This is not blocking, and you can followup in a separate PR.)

Are all of these divs necessary to get the desired styling, I feel like some of these could be redundant.

calellowitz
calellowitz approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@calellowitz calellowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I share sravan's reservations about the complexity of the html, and in general UI changes should match the styling of the rest of the site for consistency, but given the priority of this, I will merge for now

@calellowitz calellowitz merged commit cc34026 into main Nov 21, 2024
5 checks passed
@calellowitz calellowitz deleted the hy/user-profile-changes branch November 21, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxwxnvermx pxwxnvermx pxwxnvermx approved these changes

@calellowitz calellowitz calellowitz approved these changes

@sravfeyn sravfeyn sravfeyn approved these changes

Assignees

@hemant10yadav hemant10yadav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hemant10yadav @sravfeyn @calellowitz @pxwxnvermx