-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resending invites #438
base: main
Are you sure you want to change the base?
Resending invites #438
Changes from all commits
ecfa5d8
a183001
f72eddb
a1b72d6
4f770f8
2a4b9ce
d4cf965
9a6282e
56493c3
41988da
77eabc9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# Generated by Django 4.2.5 on 2024-12-10 06:05 | ||
|
||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
dependencies = [ | ||
("opportunity", "0062_opportunityaccess_invited_date"), | ||
] | ||
|
||
operations = [ | ||
migrations.AddField( | ||
model_name="userinvite", | ||
name="notification_date", | ||
field=models.DateTimeField(null=True), | ||
), | ||
] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -391,6 +391,8 @@ <h2 class="accordion-header" id="headingTwo"> | |
</div> | ||
</div> | ||
</div> | ||
|
||
|
||
{% endblock content %} | ||
|
||
{% block modal %} | ||
|
@@ -568,4 +570,23 @@ <h1 class="modal-title fs-5 text-white">{% translate "Import Catchment Areas" %} | |
</div> | ||
</div> | ||
|
||
<div class="modal fade" id="resendInviteModal" tabindex="-1" aria-labelledby="resendInviteModalLabel" aria-hidden="true"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we change the current modal implementation to bootstrap alerts to show any responses returned from the server? This will keep the UX similar across the website. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am happy to do that. I assume it would be shown at the top level, but the problem is that when the user scrolls down, they won't see the alert unless they manually scroll back up to the top, or we trigger the scroll. |
||
<div class="modal-dialog"> | ||
<div class="modal-content"> | ||
<div class="modal-header"> | ||
<h5 class="modal-title" id="resendInviteModalLabel">Alert</h5> | ||
<button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button> | ||
</div> | ||
<div class="modal-body" id="modalBodyContent"> | ||
<!-- HTMX will inject the response content here --> | ||
</div> | ||
<div class="modal-footer"> | ||
<button type="button" class="btn btn-secondary" data-bs-dismiss="modal">Close</button> | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
|
||
|
||
|
||
{% endblock modal %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for this check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the SID is not present, then the SMS is not sent, right? And if the SMS is not sent, we do not set the timestamp, so the user can trigger it again before 24 hours. Otherwise, if we set it to
now()
every time, the user won't be able to send the SMS again before 24 hours, even though the SMS was not sent earlier.