Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserMessageStatus build method error #436

Closed
wants to merge 3 commits into from

Conversation

pxwxnvermx
Copy link
Contributor

This fixes the UserMessageStatus.build method error when supplied with the error parameter.

Error Link

@pxwxnvermx
Copy link
Contributor Author

@calellowitz This fix currently lets the UserMessageStatus.build accept any extra params passed through the *args and **kwargs. It does not do anything with the error param. Do you have any thoughts for what could be done with the error that is passed from ConnectID to Connect through the error param?

@calellowitz
Copy link
Collaborator

calellowitz commented Nov 20, 2024

Do you know why it is erroring? That may be more important than what we do with the error message. Erroring like this so it ends up in sentry isn't a bad behavior, and may even be better than silently swallowing it

@pxwxnvermx pxwxnvermx closed this Dec 11, 2024
@pxwxnvermx pxwxnvermx deleted the pkv/user-message-status-error branch December 11, 2024 11:13
@pxwxnvermx pxwxnvermx restored the pkv/user-message-status-error branch December 11, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants