-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Payment Unit: Start/End Dates #421
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. But aren't there any larger implications when we introduce start/end dates for payment units like when claiming or when counting user progress etc?
@sravfeyn We let the users claim the full payment unit amount and max totals. Most opportunities are planned around a fixed number of users, so partial claiming based on the difference between the claiming date and the end date can be added later if a need comes up for that. The current spec needed start and end dates for payment units only. |
Ticket