Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment Unit: Start/End Dates #421

Merged
merged 8 commits into from
Nov 27, 2024
Merged

Conversation

pxwxnvermx
Copy link
Contributor

@pxwxnvermx pxwxnvermx commented Oct 30, 2024

@pxwxnvermx pxwxnvermx self-assigned this Oct 30, 2024
@pxwxnvermx pxwxnvermx marked this pull request as ready for review November 4, 2024 11:04
@pxwxnvermx pxwxnvermx changed the title DRAFT: Payment Unit: Start/End Dates Payment Unit: Start/End Dates Nov 4, 2024
Copy link
Member

@sravfeyn sravfeyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. But aren't there any larger implications when we introduce start/end dates for payment units like when claiming or when counting user progress etc?

@pxwxnvermx
Copy link
Contributor Author

@sravfeyn We let the users claim the full payment unit amount and max totals. Most opportunities are planned around a fixed number of users, so partial claiming based on the difference between the claiming date and the end date can be added later if a need comes up for that. The current spec needed start and end dates for payment units only.

@pxwxnvermx pxwxnvermx merged commit 362dd42 into main Nov 27, 2024
5 checks passed
@pxwxnvermx pxwxnvermx deleted the pkv/payment-unit-start-end-dates branch November 27, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants