Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opportunity APIs Tests #184

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Opportunity APIs Tests #184

merged 5 commits into from
Dec 1, 2023

Conversation

pxwxnvermx
Copy link
Contributor

@pxwxnvermx pxwxnvermx commented Oct 26, 2023

This PR adds tests for all the apis which are in the Opportunity django project. Also removed unused factories and fixtures.

@pxwxnvermx pxwxnvermx self-assigned this Oct 26, 2023
@pxwxnvermx pxwxnvermx marked this pull request as ready for review October 26, 2023 12:13
@pxwxnvermx pxwxnvermx requested a review from snopoke October 30, 2023 15:41
Copy link
Collaborator

@calellowitz calellowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Is there a reason you are checking the length of the keys instead of the content

@pxwxnvermx
Copy link
Contributor Author

Yeah, i am only creating a single object which is sent back through the API, so just checking the length of the list of objects in the response.

@pxwxnvermx pxwxnvermx merged commit c18b716 into main Dec 1, 2023
2 checks passed
@pxwxnvermx pxwxnvermx deleted the pkv/opportunity-api-tests branch December 1, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants