Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Deliver Units instead of 'forms' #139

Merged
merged 9 commits into from
Oct 5, 2023
Merged

Use Deliver Units instead of 'forms' #139

merged 9 commits into from
Oct 5, 2023

Conversation

snopoke
Copy link
Collaborator

@snopoke snopoke commented Sep 29, 2023

Jira: https://dimagi-dev.atlassian.net/browse/CCPC-127

This updates the app to use delivery units instead of delivery forms:

  • Creating an opportunity no longer requires you to select a delivery form, just a delivery app
  • Form processing updated to process deliver unit XML blocks
  • View and export updated to show deliver unit data

Copy link
Collaborator

@calellowitz calellowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intent here that these are entirely configured in HQ? That they are dynamically created in CCC based on received forms rather than matching hq forms to preconfigured units in CCC? I think that is potentially fine, but it might make some of the payment work trickier, since we will still need to associate these with payment configuration. Did you have a sense of how that would work? Otherwise, this looks great

@snopoke
Copy link
Collaborator Author

snopoke commented Oct 5, 2023

Is the intent here that these are entirely configured in HQ? That they are dynamically created in CCC based on received forms rather than matching hq forms to preconfigured units in CCC? I think that is potentially fine, but it might make some of the payment work trickier, since we will still need to associate these with payment configuration. Did you have a sense of how that would work? Otherwise, this looks great

That was my initial thought. We could easily parse them out of the app in the same way we do for learn modules.

One general issue with this approach is how to ensure that the data in Connect is kept in sync with the app e.g. if a new version is released that changes the learn / delivery blocks.

@snopoke snopoke merged commit 86f67d7 into main Oct 5, 2023
@snopoke snopoke deleted the sk/deliver-units branch October 5, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants