Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user invite and acceptance workflow #113

Merged
merged 10 commits into from
Sep 26, 2023
Merged

add user invite and acceptance workflow #113

merged 10 commits into from
Sep 26, 2023

Conversation

calellowitz
Copy link
Collaborator

This adds a simple user invite workflow (receive sms, visit magic link), and some other updates to how we save users based on the onboarding specs. It does not implement credentialing yet.

commcare_connect/users/helpers.py Outdated Show resolved Hide resolved
commcare_connect/users/helpers.py Outdated Show resolved Hide resolved
commcare_connect/utils/sms.py Show resolved Hide resolved
config/settings/base.py Outdated Show resolved Hide resolved
commcare_connect/users/helpers.py Show resolved Hide resolved
@snopoke
Copy link
Collaborator

snopoke commented Sep 14, 2023

Tests erroring on 'conflicting migrations'. I think merging main should resolve.

Lint failing (should probably install the pre-commit hooks pre-commit install):

flake8...................................................................Failed
- hook id: flake8
- exit code: 1

commcare_connect/opportunity/models.py:176:5: F811 redefinition of unused 'Meta' from line 145
commcare_connect/opportunity/views.py:221:120: E501 line too long (145 > 119 characters)
commcare_connect/users/helpers.py:41:16: F821 undefined name 'reverse'
commcare_connect/users/helpers.py:43:120: E501 line too long (161 > 119 characters)

@@ -20,6 +21,7 @@ django-model-utils
django-allauth
django-celery-beat
django-crispy-forms
django-phonenumber-field[phonenumberslite]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to have this extra dependency? This data comes straight from CCID with no way to edit it in CCC so it doesn't seem that useful to have the extra validation and support.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. I can remove it.

@calellowitz calellowitz merged commit d092413 into main Sep 26, 2023
@calellowitz calellowitz deleted the ce/user-invites branch September 26, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants