Remove OneToOne user, add unique_together user and opportunity on Opportunity Access #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snopoke
approved these changes
Sep 12, 2023
calellowitz
approved these changes
Sep 12, 2023
pxwxnvermx
deleted the
pkv/fix-opportunity-access-model-user-foreign-key
branch
pxwxnvermx
restored the
pkv/fix-opportunity-access-model-user-foreign-key
branch
pxwxnvermx
deleted the
pkv/fix-opportunity-access-model-user-foreign-key
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The OneToOne foriegn key on user field on Opportunity Access model blocked the user to have access to different opportunity because the OneToOne field also creates a unique index on the field leading to a unique constraint violation when we tried to create access to multiple opportunities for a User.
Fix: Removed OneToOne on user and added a unique together for opportunity and user since a user can have access to a single opportunity only once.