Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email as environment variable #6381

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

Charl1996
Copy link
Contributor

@Charl1996 Charl1996 commented Sep 2, 2024

Ticket

This PR simply adds an environment variable containing an email address that is used in HQ. This is needed so that local hosting projects' statistics don't end up spamming the inbox of this email address. See related HQ PR here.

Environments Affected

Staging/Production

No announcements needed.

@Charl1996 Charl1996 merged commit 233d572 into master Sep 4, 2024
2 checks passed
@Charl1996 Charl1996 deleted the cs/SC-3844-email-as-env-var branch September 4, 2024 09:16
@gherceg
Copy link
Contributor

gherceg commented Sep 17, 2024

@Charl1996 did you run update-config to apply this change? I should have mentioned that in my review, but that is necessary to get local settings updated on the targeted environment. A deploy won't actually update local settings.

Fwiw, it has since been updated, but now a restart would be necessary for the settings to take effect, which a deploy will do.

@Charl1996
Copy link
Contributor Author

@gherceg

did you run update-config to apply this change?

Nope, but thanks for highlighting this!

it has since been updated, but now a restart would be necessary for the settings to take effect, which a deploy will do

Ok, then I'll just leave it. The change is only needed from next Monday, so the deploy this week should handle this. Thus nothing for me to do now.

Thanks for bringing this up, though. Now I know.

@mkangia
Copy link
Contributor

mkangia commented Sep 19, 2024

Thanks for the follow up @gherceg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants