CCCT-533- ui icon changes as per the new figma

[pm-dimagi]

https://dimagi.atlassian.net/browse/CCCT-533

The ui changes
-- Icon update
-- commcare logo update

Safety Assurance

• If the PR is high risk, "High Risk" label is set
• I have confidence that this PR will not introduce a regression for the reasons below
• Do we need to enhance manual QA test coverage ? If yes, "QA Note" label is set correctly

Automated test coverage

Safety story

Release Note: Updated Iconography and Logo

[shubham1g5]

The code changes looks fine.

1. Is it possible to add screenshots in the PR on how it looks in the app ?
2. Is it possible to use vector drawables insted of png to take into account different screen densities.

[pm-dimagi]

@avazirna

[avazirna]

@pm-dimagi can you include a screenshot of the full Home screen, with the Incomplete and Saved buttons?

[pm-dimagi]

[shubham1g5]

Changes looks good to me. It's a good idea to add a release note to any big changes like this and also tick the safety checklist in PR template.

[avazirna]

@damagatchi retest this please

[kcowger]

@pm-dimagi I'm seeing a different design (different icons, different icon sizes) on the final assets provided to SaaS here: https://www.figma.com/design/UWjp1wRNAO0o9q2llwDKMc/CommCare-Cosmetic-Changes-Post-Nov-'22Rebrand?node-id=111-2&node-type=canvas

Can you confirm where you got these icons and icon sizes? I want to make sure we are working on off of the same assets.

[pm-dimagi]

@kcowger i downloaded the assets from the figma file only not got any icon sizes
I got this figma file for refrence https://www.figma.com/design/UWjp1wRNAO0o9q2llwDKMc/CommCare-Cosmetic-Changes-Post-Nov-'22Rebrand?node-id=625-2&node-type=canvas&t=ijXRvUyGF2lRrV6G-0

[pm-dimagi]

some revamp in colors

[shubham1g5]

Changes looks good, but tests seems to be failing -

org.commcare.android.tests.application.AppUpdateTest > testAppUpdate FAILED
21:09:01     java.lang.ExceptionInInitializerError at AppUpdateTest.kt:197
21:09:01         Caused by: java.lang.IllegalStateException at AppUpdateTest.kt:197
21:09:01 
21:09:01 org.commcare.android.tests.application.AppUpdateTest > testUpdateToBrokenApp FAILED
21:09:01     java.lang.NoClassDefFoundError at AppUpdateTest.kt:197
21:09:02 
21:09:02 org.commcare.android.tests.application.AppUpdateTest > testAppIsUpToDate FAILED
21:09:02     java.lang.NoClassDefFoundError at AppUpdateTest.kt:197
21:09:03 
21:09:03 org.commcare.android.tests.application.AppUpdateTest > testAppUpdateWithSuiteFixture FAILED
21:09:03     java.lang.NoClassDefFoundError at AppUpdateTest.kt:197
21:09:03 
21:09:03 org.commcare.android.tests.application.AppUpdateTest > testUpdateToAppWithIncompatibleVersion FAILED
21:09:03     java.lang.NoClassDefFoundError at AppUpdateTest.kt:197
21:09:04 
21:09:04 org.commcare.android.tests.application.AppUpdateTest > testUpdateToAppWithMultimedia FAILED
21:09:04     java.lang.NoClassDefFoundError at AppUpdateTest.kt:197

[avazirna]

some revamp in colors

@pm-dimagi from this screenshot, it seems that the app bar colour was not updated according with the new design, will that be address in a separate PR?

[pm-dimagi]

Yess

…

On Wed, 20 Nov, 2024, 6:28 pm Ahmad Treptt Vazirna, < ***@***.***> wrote: some revamp in colors @pm-dimagi <https://github.com/pm-dimagi> from this screenshot, it seems that the app bar colour was not updated according with the new design, will that be address in a separate PR? — Reply to this email directly, view it on GitHub <#2892 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BI42OB56IT443K7YRZGYXLL2BSBN5AVCNFSM6AAAAABRSPSVSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBYGUYTQMRQGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[pm-dimagi]

@damagatchi please retest this

[OrangeAndGreen]

@damagatchi retest this please

[pm-dimagi]

@damagatchi retest this please

[pm-dimagi]

@damagatchi retest this please

[shubham1g5]

@pm-dimagi FYI that In your last screenshot, the text on the log out button is getting cut off.