Remove Multidex usages #2871
Remove Multidex usages #2871
Conversation
Since the min SDK is 21, it is no longer necessary to use the Multidex library. See the following for more info: developer.android.com/build/multidex#mdex-on-l
|
Can one of the admins verify this patch? |
| @@ -40,7 +40,6 @@ git clone https://github.com/dimagi/commcare-core.git | |||
| - Click "OK" to use the Gradle wrapper | |||
| - Wait while Android Studio spins its wheels | |||
| - Download any build dependencies that the SDK Manager tells you you need. | |||
| - Disable _Instant Run_ found in Settings > Build, Execution, Deployment > Instant Run. (It does not play well with multidexing, which we have enabled, or with some of the processes we have set up for Google Services) | |||
There was a problem hiding this comment.
That menu doesn't seem to exist anymore, so I took the liberty to remove the whole line. I can just remove the part about Multidex if you prefer.
There was a problem hiding this comment.
thanks for clearing this up!
|
I see that the Linter check is failing. If I run the |
|
@damagatchi ok to test |
|
@MGaetan89 Unfortunately our lint check checks for the complete files instead of the lines you changed. I see that there are no failures corresponding to your changes so it's fine to ignore the lint failure at the moment. Thanks! |
|
@damagatchi retest this please |
|
@damagatchi retest this please |
1 similar comment
|
@damagatchi retest this please |
|
Facing some issues with memory config on Jenkins, retuned and retrying build. |
|
@damagatchi retest this please |
Summary
Since the min SDK is 21, it is no longer necessary to use the Multidex library.
See the following for more info: https://developer.android.com/build/multidex#mdex-on-l
Safety Assurance
Automated test coverage
Safety story