Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for translations to fetch from server for repeat group … #2843

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Added support for translations to fetch from server for repeat group … #2843

merged 7 commits into from
Sep 30, 2024

Conversation

devanshhooda
Copy link
Contributor

@devanshhooda devanshhooda commented Sep 11, 2024 •
edited by shubham1g5
Loading

Summary

This PR addresses the changes required for issue: 2795

Product Description

We are now fetching the custom translations from the server for the elements of repeat groups.

Safety Assurance

  • I have confidence that this PR will not introduce a regression for the reasons below
  • Do we need to enhance manual QA test coverage ? If yes, "QA Note" label is set correctly

SS from commcarehq:
Screenshot 2024-09-11 at 4 25 36 PM

App SS:
Screenshot_20240911_162358
Screenshot_20240911_162419

Release Note: Adds support for custom translations for "Add" button in repeat group

@devanshhooda devanshhooda self-assigned this Sep 11, 2024
@devanshhooda devanshhooda linked an issue Sep 11, 2024 that may be closed by this pull request
Add Support for custom translations for "Add New" and "Add Another" buttons for Repeat Group #2795
Closed
shubham1g5
shubham1g5 requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@shubham1g5 shubham1g5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks right, added a suggestion to remove comments.

app/src/org/commcare/activities/FormEntryActivityUIController.java Outdated Show resolved Hide resolved
@devanshhooda devanshhooda added the skip-integration-tests Skip android tests. label Sep 20, 2024
@devanshhooda
Copy link
Contributor Author

@damagatachi retest this please

1 similar comment
@devanshhooda
Copy link
Contributor Author

@damagatachi retest this please

@devanshhooda devanshhooda merged commit 68d2504 into master Sep 30, 2024
3 of 8 checks passed
@shubham1g5 shubham1g5 added this to the 2.55 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham1g5 shubham1g5 shubham1g5 approved these changes

Assignees

@devanshhooda devanshhooda

Labels
QA Note Release Note skip-integration-tests Skip android tests.
Projects
None yet
Milestone
2.55
Development

Successfully merging this pull request may close these issues.

Add Support for custom translations for "Add New" and "Add Another" buttons for Repeat Group
2 participants
@devanshhooda @shubham1g5