Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/givewell #2805

Merged
merged 67 commits into from
Oct 23, 2024
Merged

Feature/givewell #2805

merged 67 commits into from
Oct 23, 2024

Conversation

shubham1g5
Copy link
Contributor

@shubham1g5 shubham1g5 commented Aug 7, 2024 •
edited by avazirna
Loading

Summary

This is a collection of improvements mainly including Graceful Session Pause along with some other misc. improvements. You can look at the complete list of PRs included below -

Feature Flag

Product Description

Safety Assurance

  • If the PR is high risk, "High Risk" label is set
  • I have confidence that this PR will not introduce a regression for the reasons below
  • Do we need to enhance manual QA test coverage ? If yes, "QA Note" label is set correctly

Automated test coverage

Safety story

cross-request: dimagi/commcare-core#1437

@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

1 similar comment
@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5
Copy link
Contributor Author

HQ seems to be lagging to cause tests to fail and all failures look unrelated, running build with skipping integration tests to get the apk.

@shubham1g5 shubham1g5 added the skip-integration-tests Skip android tests. label Aug 7, 2024
@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5 shubham1g5 changed the base branch from master to commcare_2.54 August 8, 2024 10:31
@shubham1g5 shubham1g5 removed the skip-integration-tests Skip android tests. label Aug 8, 2024
@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5 shubham1g5 added the skip-integration-tests Skip android tests. label Aug 8, 2024
@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

12 similar comments
@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5 shubham1g5 removed the skip-integration-tests Skip android tests. label Aug 9, 2024
@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5 shubham1g5 added the skip-integration-tests Skip android tests. label Aug 9, 2024
@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5 shubham1g5 removed the skip-integration-tests Skip android tests. label Sep 5, 2024
@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

1 similar comment
@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@avazirna avazirna removed the skip-integration-tests Skip android tests. label Sep 20, 2024
@avazirna
Copy link
Contributor

@damagatchi retest this please

@avazirna avazirna added the skip-integration-tests Skip android tests. label Sep 20, 2024
avazirna and others added 12 commits September 20, 2024 14:56
@avazirna
Merge pull request #2857 from dimagi/add-form-instance-id-to-interrup…
57a5117 
…ted-form-state-model

Add FormInstanceId to InterruptedFormState model
@avazirna
Nit
eaba92b
@avazirna
Merge pull request #2859 from dimagi/quarantine-malformed-form-xml-as…
503c57c 
…-unrecoverable

Quarantine forms due to malformed xml as unrecoverable
@avazirna
Refactor
296dc38
@avazirna
Revert "Remove exit flag from formSaveCallback"
6aaf0ff 
This reverts commit 2c3b7bb.
@avazirna
Refactor
3ade9b2
@avazirna
Make class field nullable
7218aba
@avazirna
Merge branch 'feature/givewell' into adjust-user-messages-when-autosa…
a776076 
…ving-session-form
@avazirna
Nit
a27ab98
@avazirna
Correct userTriggered flag when updating attachments
019cd2d
@avazirna
Refactor
dec7568
@avazirna
Merge pull request #2858 from dimagi/adjust-user-messages-when-autosa…
aebd94e 
…ving-session-form

Adjust user messages around the Session Pause feature
@avazirna avazirna marked this pull request as ready for review October 23, 2024 16:47
@avazirna
Copy link
Contributor

@damagatchi retest this please

@avazirna avazirna removed the skip-integration-tests Skip android tests. label Oct 23, 2024
@avazirna
Copy link
Contributor

@damagatchi retest this please

2 similar comments
@avazirna
Copy link
Contributor

@damagatchi retest this please

@avazirna
Copy link
Contributor

@damagatchi retest this please

@avazirna avazirna merged commit 6bd56ed into commcare_2.54 Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cross requested
Projects
None yet
Milestone
2.54.1
Development

Successfully merging this pull request may close these issues.
3 participants
@shubham1g5 @avazirna @ctsims