Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust case detail display text column when empty #2762

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

avazirna
Copy link
Contributor

@avazirna avazirna commented Jun 10, 2024

Summary

This PR introduces minor changes to the layout of case detail items to better handle empty display texts.

Ticket: https://dimagi.atlassian.net/browse/SAAS-12631

Product Description

For horizontal orientation:

Before After

Safety Assurance

  • I have confidence that this PR will not introduce a regression for the reasons below

@avazirna avazirna marked this pull request as ready for review June 11, 2024 07:42
@avazirna
Copy link
Contributor Author

avazirna commented Jun 11, 2024

@damagatchi retest this please

2 similar comments
@avazirna
Copy link
Contributor Author

@damagatchi retest this please

@avazirna
Copy link
Contributor Author

@damagatchi retest this please

Copy link
Contributor

@shubham1g5 shubham1g5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Should have a release note set as this is a change is behaviour.

@avazirna avazirna added this to the 2.55 milestone Jun 18, 2024
@avazirna
Copy link
Contributor Author

@damagatchi retest this please

1 similar comment
@avazirna
Copy link
Contributor Author

@damagatchi retest this please

@avazirna avazirna merged commit 2aaaff2 into master Jun 24, 2024
4 of 6 checks passed
@avazirna avazirna deleted the adjust-case-detail-display-text-when-empty branch June 24, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants