Providing API version header from server to caller when available. #2757
Conversation
|
|
||
| @Override | ||
| public String getApiVersion() { | ||
| return apiVersion; |
There was a problem hiding this comment.
how about return requester.getApiVersion() ?
Also is this API version connect only or will also be added to non connect server calls ?
There was a problem hiding this comment.
Ah, excellent suggestion, I'll do that!
Currently both the ConnectId and Connect servers are returning this header. I'm not sure about any plans for HQ to use it.
…ttempting to parse it separately.
Addressed linter errors in several files
|
@damagatchi Retest this please |
…essor when call completed instead of implementing it as a class and passing 'this'. Lint.
…nto dv/api_versioning
|
@damagatchi retest this please |
3 similar comments
|
@damagatchi retest this please |
|
@damagatchi retest this please |
|
@damagatchi retest this please |
|
@damagatchi retest this please Since the core PR is merged without these changes we are now breaking the master build. Our integration tests are failing currently due to Password provisioning, hence I am running without integration tests to be able to merge this. |
|
Ah, yes, thanks for that. I'd considered skipping the integration tests as well since the failures didn't seem related to these changes, but wasn't sure whether that would be advised. |
Attempts to safely retrieve the x-api-current-version header from API response payloads so calling code can do version checking.
https://dimagi.atlassian.net/browse/CCCT-239
cross-request: dimagi/commcare-core#1409