Added cccStaging build flavor #2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham1g5
reviewed
Nov 1, 2023
| @@ -333,6 +336,10 @@ android { | |||
| manifest.srcFile 'CommcareAndroidManifest.xml' | |||
| } | |||
|
|
|||
| cccStaging { | |||
| manifest.srcFile 'CommcareAndroidManifest.xml' | |||
There was a problem hiding this comment.
Hmm... good question! I assumed so since it's specified instead of the default for both commcare and lts, but looking into CommcareAndroidManifest.xml it seems like maybe it's just for adding some extra shortcuts?
There was a problem hiding this comment.
I can try removing it and see if things work, although I'm not sure what error to look for other than just making sure the app installs and launches successfully.
shubham1g5
approved these changes
Nov 1, 2023
|
@damagatchi retest this please |
|
Merging to unblock other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New cccStaging build flavor in order to support Connect production and staging versions.