Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectId #2696

Open
wants to merge 110 commits into
base: master
Choose a base branch
from
Open

ConnectId #2696

wants to merge 110 commits into from

Conversation

OrangeAndGreen
Copy link
Contributor

Summary

Feature branch for CommCare Connect work

Product Description

Adds functionality for CommCare Connect.
User can register/recover a ConnectID account from the app login page.
User can unlock ConnectID once account has been registered/recovered.
When CID is unlocked, user can login to apps automatically using passwords that are securely stored in the app.

Safety Assurance

  • If the PR is high risk, "High Risk" label is set
  • I have confidence that this PR will not introduce a regression for the reasons below
  • Do we need to enhance manual QA test coverage ? If yes, "QA Note" label is set correctly

Safety story

QA has a test plan for ConnectID functionality so far.

OrangeAndGreen and others added 30 commits March 2, 2023 10:58
@OrangeAndGreen
Initial work on ConnectId UI and some intro logic. Working toward POC.
6153242
@OrangeAndGreen
Got rid of locked state for Connect ID (only logged out or logged in).
466026c 
Getting ready for network calls.
@OrangeAndGreen
Renamed some files for consistency.
06f9936 
Initial registration workflow working.
Implemented basic photos page and SMS verification.
@OrangeAndGreen
Changes to initial ConnectID create/recovery workflow.
6d7b527 
Basic password manager implementation after ConnectID login.
@OrangeAndGreen
A few look-and-feel changes
87c6d0f
@OrangeAndGreen
Merge remote-tracking branch 'origin/master' into dv/connect_id
1bfa868
@OrangeAndGreen
Disabling ConnectID functionality by default.
d16af33
@OrangeAndGreen
Changed min SDK to 23.
a60a863 
Implemented local encrypted DB for data related to Connect.
@OrangeAndGreen
Added activity for getting Connect recovery vs. new account decision.
e2cb6cb 
Some cleanup after achieving POC functionality.
Using secure storage for password manager functionality.
@OrangeAndGreen
Fixed recently introduced crash after server error on Connect registr…
f07b4ed 
…ation call.
@OrangeAndGreen
Remembering registration phase to resume after app interruption.
5bd6747 
Several UI improvements, rewording.
@OrangeAndGreen
Icons instead of highlighted text on two pages.
0cf3b66 
A couple small bug fixes.
Preparing for OIDC calls.
@OrangeAndGreen
ConnectID V1 development, including several new activities.
52b1bb7 
Moved ConnectID activities into a sub-namespace called connect.
@OrangeAndGreen
Added ConnectID unlock functionality as a developer option.
e5590c6 
Showing recovery phone number in UI when sending alt OTP.
@OrangeAndGreen
Improved ConnectID DB encryption using Android KeyStore.
db457b4 
Now encrypting DB passphrase using a Cipher, and storing the encrypted passphrase in the global DB.
Added table to global DB for storing ConnectKeyRecords (changed DB version to 6).
Min SDK Version moved back to 16 now that we aren't using newer helper classes (EncryptedFile, MasterKeys).
@OrangeAndGreen
Quick fix: Changed a key received from the server.
23881d8
@OrangeAndGreen
Fixed bug where password sometimes wouldn't auto-fill when it should.
303cac5 
Not allowing password option when prompting for biometric unlock during registration.
Fixed bug where ConnectID button on login page would appear after logging out of an app even if ConnectID user was not configured.
Disabled auto-login to app after unlocking ConnectID.
@OrangeAndGreen
Merge remote-tracking branch 'origin/master' into dv/connect_id
74a21d6
@OrangeAndGreen
Added two new externalizable classes to list for FormStorageTest (fix…
ab4e140 
…ing a broken test).
@OrangeAndGreen
Added one more externalizable class to FormStorageTest list.
64ca2d2
@OrangeAndGreen
Added phone number checking to recovery decision page before allowing…
4db49b5 
… user to proceed to OTP page.
@OrangeAndGreen
Moved a bunch of ConnectID-related strings from android_translatable_…
a0ce2ea 
…strings.txt to strings.xml.

Re-enabled strict mode.
Small improvements to EncryptionUtils for versions before Android M.
Some other small changes based on PR review.
@OrangeAndGreen
Added some (temporary) error reporting to API call that checks if pho…
2c35dfb 
…ne number is available, for debugging.
@OrangeAndGreen
Styling improvements.
78bcb6a 
Added code for encrypting DB in Android version before API 23.
Fixed going to alt. phone verification after password fails three times.
Added better consent wording, links, and checkbox.
@OrangeAndGreen
Solved DB passphrase encryption for API 21 and lower.
88e094a 
Some bug fixes for QA tickets.
Better error messaging on registration and phone verification pages.
@OrangeAndGreen
Showing ConnectID page titles in blue bar at top of screen.
1cca84f 
Storing alt number in Connect DB.
Not allowing user to change primary number to match alt number.
Fixed bugs involving forgetting ConnectID user and saved app credentials.
@OrangeAndGreen
Added AppSelectActivity initial implementation (not using yet).
3fc9f5a 
Changed code to update primary phone ad main reg. info when user returns to those screens after initial creation.
Improvements to recovering workflow after crash or backup to start.
@shubham1g5
Show sign in/up if user is logged out
46aa87f
@shubham1g5
don't set parent activity null on forget user as it causes crash when…
8069967 
… user click on sign up again
@shubham1g5
Merge branch 'master' into dv/connect_id
a1c37f4
OrangeAndGreen and others added 3 commits September 28, 2023 11:57
@OrangeAndGreen
Not showing "Other options" button in fingerprint unlock dialog durin…
4f85b89 
…g registration (when there aren't any other options configured yet).
@OrangeAndGreen
Merge pull request #2714 from dimagi/dv/phone_number_fix
8745a99 
Fixed populating phone number input from existing phone number.
@OrangeAndGreen
Merge pull request #2715 from dimagi/dv/fingerprint_options
e1a4462 
Not showing the "Other Options" button on the fingerprint unlock dialog when it is shown during ConnectID registration.
@shubham1g5
Copy link
Contributor

@damagatchi retest this please

@shubham1g5 shubham1g5 added the skip-integration-tests Skip android tests. label Sep 29, 2023
@shubham1g5
Copy link
Contributor

@damagatchi retest this please

@OrangeAndGreen
Copy link
Contributor Author

@damagatchi retest this please.

@OrangeAndGreen
Copy link
Contributor Author

@damagatchi retest this please

@OrangeAndGreen OrangeAndGreen removed the skip-integration-tests Skip android tests. label Mar 18, 2024
@OrangeAndGreen
Copy link
Contributor Author

@damagatchi Retest this please

1 similar comment
@OrangeAndGreen
Copy link
Contributor Author

@damagatchi Retest this please

@OrangeAndGreen
Copy link
Contributor Author

@damagatchi Retest this please

1 similar comment
@OrangeAndGreen
Copy link
Contributor Author

@damagatchi Retest this please

@OrangeAndGreen
Copy link
Contributor Author

@damagatchi retest this please

@OrangeAndGreen OrangeAndGreen changed the title CommCare Connect ConnectId Jul 10, 2024
@OrangeAndGreen
Copy link
Contributor Author

@damagatchi retest this please

@avazirna avazirna modified the milestones: 2.55, 2.56 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham1g5 shubham1g5 shubham1g5 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@OrangeAndGreen OrangeAndGreen

Labels
High Risk If the PR introduce high risk changes that has high probability of introducing breaking changes
Projects
None yet
Milestone
2.56
Development

Successfully merging this pull request may close these issues.
3 participants
@OrangeAndGreen @shubham1g5 @avazirna