Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps: add support for termination configuration. #1297

Merged
merged 1 commit into from
Jan 6, 2025
Merged

apps: add support for termination configuration. #1297

merged 1 commit into from
Jan 6, 2025

Conversation

andrewsomething
Copy link
Member

@loosla
Copy link
Contributor

loosla commented Dec 31, 2024 •
edited
Loading

Looks awesome 🙌
Sorry, looks like we add defaults in schema. Could you add defaults for drain_seconds and grace_period_seconds, please? 🙏

@loosla
Copy link
Contributor

loosla commented Dec 31, 2024

Also, noticed that the instance_count in worker is forced to be updated each time even if it's value hasn't been changed.
Constantly see it in changes on terraform plan.
However, this is not related to Apps Termination feature.

ddelange
ddelange approved these changes Jan 5, 2025
View reviewed changes
Copy link

@ddelange ddelange left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks for adding min and max values to the docs!

@andrewsomething andrewsomething requested a review from a team January 6, 2025 15:44
@andrewsomething
Copy link
Member Author

Rebased main to resolve conflicts.

@loosla I don't think we want to hardcode the defaults in this case. This allows more flexibility on the API side. When it's enforced there, they can be updated without needing to rebuild/re-release the provider.

@andrewsomething andrewsomething merged commit ce3608f into main Jan 6, 2025
5 checks passed
@andrewsomething andrewsomething deleted the asb/issues/1275 branch January 6, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddelange ddelange ddelange approved these changes

@bentranter bentranter bentranter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

digitalocean_app: add termination block (drain_seconds and grace_period_seconds)
4 participants
@andrewsomething @loosla @bentranter @ddelange