Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LBAAS: increase maximum lb size_unit, add regional_network type support #1284

Conversation

jvasilevsky
Copy link
Contributor

@jvasilevsky jvasilevsky commented Dec 2, 2024

Some small fixes for things we already support but have not been added to terraform:

  • increase maximum lb size_unit to 200
  • add regional_network type support

@jvasilevsky jvasilevsky force-pushed the jvasilevsky/LBAAS-increase-max-lb-size-unit branch from 85907e3 to 09b7eb0 Compare December 2, 2024 20:35
@jvasilevsky jvasilevsky changed the title LBAAS: increase maximum lb size_unit LBAAS: increase maximum lb size_unit, add regional_network type support Dec 2, 2024
@jvasilevsky jvasilevsky marked this pull request as ready for review December 2, 2024 20:58
@loosla
Copy link
Contributor

loosla commented Dec 2, 2024

Looks good to me 👏
Could you please also update the doc 🙏

* `type` - (Optional) The type of the Load Balancer. It must be either of `REGIONAL` or `GLOBAL`. Defaults to `REGIONAL`.
**NOTE**: non-`REGIONAL/GLOBAL` type may be part of closed beta feature and not available for public use.

- add REGIONAL_NETWORK in docs
- update max size in docs
@jvasilevsky jvasilevsky force-pushed the jvasilevsky/LBAAS-increase-max-lb-size-unit branch from f6c47e7 to 7aa7c56 Compare December 3, 2024 15:23
Copy link
Contributor

@loosla loosla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🚀 Many thanks! Looks great.

@loosla loosla merged commit 72324a2 into digitalocean:main Dec 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants