Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uptime alerts: fix importing existing alerts #1119

Merged
merged 3 commits into from
Mar 4, 2024
Merged

uptime alerts: fix importing existing alerts #1119

merged 3 commits into from
Mar 4, 2024

Conversation

andrewsomething
Copy link
Member

Importing an uptime alert requires knowing the ID of its parent uptime check.

Fixes: #1118

$ make testacc PKG_NAME=digitaloc
ean/uptime
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -v ./digitalocean/uptime/...  -timeout 120m -parallel=2
=== RUN   TestAccDigitalOceanUptimeAlert_importBasic
=== PAUSE TestAccDigitalOceanUptimeAlert_importBasic
=== RUN   TestAccDigitalOceanUptimeAlert_Basic
=== PAUSE TestAccDigitalOceanUptimeAlert_Basic
=== RUN   TestAccDigitalOceanUptimeCheck_Basic
=== PAUSE TestAccDigitalOceanUptimeCheck_Basic
=== CONT  TestAccDigitalOceanUptimeAlert_importBasic
=== CONT  TestAccDigitalOceanUptimeCheck_Basic
--- PASS: TestAccDigitalOceanUptimeCheck_Basic (15.04s)
=== CONT  TestAccDigitalOceanUptimeAlert_Basic
--- PASS: TestAccDigitalOceanUptimeAlert_importBasic (15.42s)
--- PASS: TestAccDigitalOceanUptimeAlert_Basic (9.00s)
PASS
ok      github.com/digitalocean/terraform-provider-digitalocean/digitalocean/uptime     24.055s

@andrewsomething andrewsomething mentioned this pull request Mar 1, 2024
Closed
fabn
fabn approved these changes Mar 2, 2024
View reviewed changes
Copy link

@fabn fabn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

danaelhe
danaelhe approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrewsomething andrewsomething merged commit 70fc600 into main Mar 4, 2024
3 checks passed
@andrewsomething andrewsomething deleted the asb/issues/1118 branch March 4, 2024 15:28
@fabn
Copy link

fabn commented Mar 9, 2024

Any chance to see this released? Thanks

@danaelhe
Copy link
Member

Any chance to see this released? Thanks

Yes- I can create one now!

@danaelhe
Copy link
Member

Any chance to see this released? Thanks

New release cut via v2.36.0

@fabn
Copy link

fabn commented Mar 12, 2024

New release cut via v2.36.0

I don't see it 2.36 on terraform registry https://registry.terraform.io/providers/digitalocean/digitalocean/latest 🤔

@andrewsomething
Copy link
Member Author

@fabn It should now be available https://registry.terraform.io/providers/digitalocean/digitalocean/2.36.0

Apologies for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danaelhe danaelhe danaelhe approved these changes

@fabn fabn fabn approved these changes

@bentranter bentranter Awaiting requested review from bentranter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to import digitalocean_uptime_alert by id (import id is wrong)
3 participants
@andrewsomething @fabn @danaelhe