Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scalable storage settings separately for read-replica vs. primary #1103

Merged

Conversation

dweinshenker
Copy link
Contributor

@dweinshenker dweinshenker commented Jan 17, 2024

What

  • Enables read-replicas to set their own value for storage_size_mib to specify disk space
  • Resolves some outdated Mongo tests using older versions
  • Fixes resize issue for clusters when omitting storage_size_mib

@dweinshenker dweinshenker marked this pull request as draft January 17, 2024 18:00
@dweinshenker dweinshenker marked this pull request as ready for review January 17, 2024 19:46
@dweinshenker dweinshenker marked this pull request as draft January 17, 2024 20:49
@dweinshenker
Copy link
Contributor Author

Need to add some wait between a new test, there is an issue during resize of a replica

=== CONT  TestAccDigitalOceanDatabaseReplica_Resize
    resource_database_replica_test.go:120: Step 4/4 error: Error running apply: exit status 1

        Error: Error resizing database replica: PUT https://api.digitalocean.com/v2/databases/a064eaf3-6c3c-43c8-acb3-0896c539bd0e/resize: 412 (request "917dc244-069c-4a54-8c33-2396ae5ba091") update cluster cannot be performed. Reason: cluster is undergoing maintenance

          with digitalocean_database_replica.read-01,
          on terraform_plugin_test.tf line 11, in resource "digitalocean_database_replica" "read-01":
          11: resource "digitalocean_database_replica" "read-01" {

--- FAIL: TestAccDigitalOceanDatabaseReplica_Resize (822.91s)

Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Thank you!

@dweinshenker dweinshenker force-pushed the dbaas-scalable-storage-read-replicas branch from f9d9e03 to 227ebf3 Compare January 17, 2024 22:00
@dweinshenker dweinshenker marked this pull request as ready for review January 17, 2024 22:02
@danaelhe danaelhe merged commit 91272bf into digitalocean:main Jan 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants