Database Users: Update settings independent of other user settings

[dweinshenker]

What

• Prevent changes to kafka user ACLs from replacing database user resources

Why

The ability to update settings, and thus kafka user ACLs, allows for user management without replacing the user resources. Replacement of user resources is especially painful given that it will generate a new password.

Testing

Ran acceptance tests

ok  	github.com/digitalocean/terraform-provider-digitalocean/digitalocean/certificate	(cached) [no tests to run]
=== RUN   TestAccDigitalOceanDatabaseUser_KafkaACLs
=== PAUSE TestAccDigitalOceanDatabaseUser_KafkaACLs
=== CONT  TestAccDigitalOceanDatabaseUser_KafkaACLs
--- PASS: TestAccDigitalOceanDatabaseUser_KafkaACLs (289.63s)

Making a change locally to a user's ACLs on a test cluster and running terraform plan shows the user resource not being replaced anymore

Terraform will perform the following actions:

  # digitalocean_database_user.kafka-acl-user-1 will be updated in-place
  ~ resource "digitalocean_database_user" "kafka-acl-user-1" {
        id         = "352c8602-261c-4c00-a2e2-0130f015e243/user/kafka-acl-user-1"
        name       = "kafka-acl-user-1"
        # (3 unchanged attributes hidden)

      ~ settings {
          ~ acl {
                id         = "acl47b234cbe22"
              ~ permission = "produce" -> "consume"
              ~ topic      = "topic-3" -> "topic-5"
            }

            # (1 unchanged block hidden)
        }
    }

Plan: 0 to add, 1 to change, 0 to destroy.

──────────────────────────────────────────────────

Calling the DO API shows the updates taking place:

{
            "name": "kafka-acl-user-1",
            "role": "normal",
            "password": ".......",
            "settings": {
                "acl": [
                    {
                        "id": "acl47b2c79825a",
                        "permission": "consume",
                        "topic": "topic-5"
                    },
                    {
                        "id": "acl47b2c7c7b24",
                        "permission": "consume",
                        "topic": "topic-4"
                    }
                ]
            }
        }

[andrewsomething]

Great stuff! 👍