-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDN: Add Support for "needs-cloudflare-cert" #1089
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @itssimon - could you give this a try? |
andrewsomething
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Think this is a great workaround for the moment.
andrewsomething
requested changes
Dec 4, 2023
andrewsomething
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1086
In order to have Cloudflare generate a certificate,
certificate_id
must be set to the value "needs-cloudflare-cert" in our API.In the Terraform provider
certificate_name
is passed in instead of acertificate_id
(we've deprecated certificate_id attribute in favor of certificate_name for digitalocean_cdn because when the certificate type is lets_encrypt, the certificate ID will change on renewal (after 3 months)), we use the name to look up the id and then set that id tocertificate_id
.....hence thecertificate_id
will not beneeds-cloudflare-cert
here:Added logic to check if
needs-cloudflare-cert
is passed intocertificate_name
to set that as thecertificate_id