Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep v2.33.0 Release #1079

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Prep v2.33.0 Release #1079

merged 6 commits into from
Nov 15, 2023

Conversation

danaelhe
Copy link
Member

No description provided.

@danaelhe danaelhe requested a review from a team November 14, 2023 21:07
andrewsomething
andrewsomething requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issues with #1078 that we should address before releasing this.

It adds port to the schema, but it is never actually used. We need to also add it in the expandAppHealthCheck and flattenAppHealthCheck functions or it will not effect anything.

@danaelhe
Copy link
Member Author

There are some issues with #1078 that we should address before releasing this.

It adds port to the schema, but it is never actually used. We need to also add it in the expandAppHealthCheck and flattenAppHealthCheck functions or it will not effect anything.

Oh yikes, good catch. I'll push a PR now.

@nemcikjan
Copy link
Contributor

@danaelhe should I fix it?

@danaelhe
Copy link
Member Author

@danaelhe should I fix it?

Thank you but it's already been fixed in #1080 👍

@andrewsomething
Copy link
Member

andrewsomething commented Nov 14, 2023 •
edited by danaelhe
Loading

FYI, I also reviewed and merged #1074 so it could make it into the release.

@danaelhe
Copy link
Member Author

FYI, I also reviewed and merged #1074 so it could make it into the release.

updated change log in latest commit 👍

@andrewsomething andrewsomething self-requested a review November 14, 2023 23:02
andrewsomething
andrewsomething reviewed Nov 14, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@danaelhe @andrewsomething
Update CHANGELOG.md
218fbbd 
Co-authored-by: Andrew Starr-Bochicchio <[email protected]>
andrewsomething
andrewsomething approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@danaelhe danaelhe merged commit a6c3d48 into main Nov 15, 2023
2 checks passed
@danaelhe danaelhe deleted the new_release branch November 15, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsomething andrewsomething andrewsomething approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danaelhe @nemcikjan @andrewsomething