Update poetry version used in CI #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentranter
previously approved these changes
Oct 12, 2023
|
😕 |
|
Seems like the issue was specific to Python 3.7. Removing that from the matrix allows poetry to be successfully installed and the tests to pass. Python 3.7 is no longer supported upstream and ended security support 3 months ago. I think it is safe to drop it from the tests. |
bentranter
approved these changes
Oct 13, 2023
andrewsomething
added a commit
to digitalocean/openapi
that referenced
this pull request
Oct 16, 2023
Updates the poetry version used in Python client validation to match the one used by pydo itself. See: digitalocean/pydo#237 Resolves errors like: ``` The lock file is not compatible with the current version of Poetry. Upgrade Poetry to be able to read the lock file or, alternatively, regenerate the lock file with the `poetry lock` command. ``` https://github.com/digitalocean/openapi/actions/runs/6526929286/job/17721187808#step:7:13
andrewsomething
added a commit
to digitalocean/openapi
that referenced
this pull request
Oct 16, 2023
Updates the poetry version used in Python client validation to match the one used by pydo itself. See: digitalocean/pydo#237 Resolves errors like: ``` The lock file is not compatible with the current version of Poetry. Upgrade Poetry to be able to read the lock file or, alternatively, regenerate the lock file with the `poetry lock` command. ``` https://github.com/digitalocean/openapi/actions/runs/6526929286/job/17721187808#step:7:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We specify poetry version 1.6.1 in most places, e.g.:
pydo/.github/workflows/pr.yaml
Line 23 in e51dee5
pydo/.github/workflows/python-client-gen.yml
Line 52 in e51dee5
But it looks like we missed updating it here. This is what is causing dependabot PRs to fail the test step.
https://github.com/digitalocean/pydo/actions/runs/6500827562/job/17657028618?pr=195