Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added test mocked tests for droplets - 1 #225

Merged
merged 3 commits into from
Oct 4, 2023
Merged

added test mocked tests for droplets - 1 #225

merged 3 commits into from
Oct 4, 2023

Conversation

work-mohit
Copy link
Contributor

fix : #208

@danaelhe danaelhe mentioned this pull request Oct 3, 2023
Merged
@danaelhe
Copy link
Member

danaelhe commented Oct 3, 2023

Awesome!! 5/7 tests addressed in #208 were addressed in another PR #223
This PR addresses the other two tests which is fantastic. Could you resolve the merge conflicts so it only includes the two tests that weren't address in #208? (destroy_by_tag and list_associated_resources)

@danaelhe danaelhe mentioned this pull request Oct 3, 2023
Closed
danaelhe
danaelhe approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome contribution!! Thank you so so much!

@danaelhe danaelhe merged commit 13340e7 into digitalocean:main Oct 4, 2023
5 checks passed
@work-mohit work-mohit deleted the droplets-1 branch October 4, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danaelhe danaelhe danaelhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Mocked Tests: Droplets (part 1)
2 participants
@work-mohit @danaelhe