Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mocked tests for databases - part 4 #218

Merged
merged 11 commits into from
Oct 3, 2023

Conversation

work-mohit
Copy link
Contributor

Refer Issue : #207

Add tests for databases.patch_config, databases.reset_auth, databases.update_cluster_size, databases.update_firewall_rules, databases.update_maintenance_window, databases.online_migration, databases.update_region, databases.update_sql_mode

for databases.promote_replica, databases.update_connection_pool,
databases.update_major_version tests were already there.

Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!! Just need to run poetry run black tests and push up the changes to resolve the lint failures 👍

@work-mohit work-mohit requested a review from danaelhe October 2, 2023 17:08
@work-mohit
Copy link
Contributor Author

have a look at this PR, I guess this is ready to merge!

@danaelhe
Copy link
Member

danaelhe commented Oct 3, 2023

The lint failure can be ignored. Add # pylint: disable=too-many-lines at the top of your file.

@work-mohit
Copy link
Contributor Author

The pushed branch have # pylint: disable=too-many-lines at the top but still failing lint tests

@danaelhe
Copy link
Member

danaelhe commented Oct 3, 2023

The pushed branch have # pylint: disable=too-many-lines at the top but still failing lint tests

it currently has # pylint: disable=line-too-long, you'll need to add # pylint: disable=too-many-lines. They're very similar 😆

@work-mohit
Copy link
Contributor Author

The pushed branch have # pylint: disable=too-many-lines at the top but still failing lint tests

it currently has # pylint: disable=line-too-long, you'll need to add # pylint: disable=too-many-lines. They're very similar 😆

yeah didn't notice 🤣🤣🤣

Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution!! Thank you so much 🚢

@danaelhe danaelhe merged commit 5a623de into digitalocean:main Oct 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants