-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added mocked tests for databases - part 4 #218
added mocked tests for databases - part 4 #218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!! Just need to run poetry run black tests
and push up the changes to resolve the lint failures 👍
have a look at this PR, I guess this is ready to merge! |
The lint failure can be ignored. Add |
The pushed branch have |
it currently has |
yeah didn't notice 🤣🤣🤣 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great contribution!! Thank you so much 🚢
Refer Issue : #207
Add tests for
databases.patch_config
,databases.reset_auth
,databases.update_cluster_size
,databases.update_firewall_rules
,databases.update_maintenance_window
,databases.online_migration
,databases.update_region
,databases.update_sql_mode
for
databases.promote_replica
,databases.update_connection_pool
,databases.update_major_version
tests were already there.