Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mocked tests for databases - part 3 #217

Merged

Conversation

work-mohit
Copy link
Contributor

Refer Issue : #206

Add tests for databases.get_user, databases.list, databases.list_backups, databases.list_clusters, databases.list_connection_pools, databases.list_firewall_rules, databases.list_options, databases.list_replicas, databases.list_users.

Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just need to run poetry run black tests and push up the changes to resolve the lint failures 👍

@work-mohit work-mohit requested a review from danaelhe October 2, 2023 17:09
Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME contribution!! Thank you so much! This is good to merge and ship :shipit:

@danaelhe danaelhe merged commit ced038e into digitalocean:main Oct 3, 2023
5 checks passed
@work-mohit work-mohit deleted the added-mocked-test-databases-3 branch October 3, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants