-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mocked Tests: Volume Actions #214
Conversation
@danaelhe am I on the right path? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shivam-Purohit Yupp doing great !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Looks great!! Apologies, I should've included in the instructions but we lint our tests with the python package black. Currently, the "lint" test is failing for this PR but it's a super easy fix. If you run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks FANTASTIC! Will merge once a commit has been pushed to fix lint tests pass (see comment from above)!
@danaelhe I pushed the changes. Is it okay now? |
I was thinking about the same. |
That's a great idea. I'll write up a github issue for it. Thanks! |
refers issue #203
Add mocked tests for volume action.
Add tests for volume_actions.get, volume_actions.list, volume_actions.post, volume_actions.post_by_id