Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce file extensions in imports to comply with ESM standards #486

Merged
merged 10 commits into from
Oct 4, 2024
Merged

Enforce file extensions in imports to comply with ESM standards #486

merged 10 commits into from
Oct 4, 2024

Conversation

dmz-v-x
Copy link
Contributor

@dmz-v-x dmz-v-x commented Oct 2, 2024

Type of Change:

Tool Source: JS

What issue does this relate to?

This PR resolves #454.

What should this PR do?

  • Removed all esm + extensionless usages from the project.
  • Updated ESLint configuration to enforce file extensions in import statements.
  • Ensured all imports in the project now include proper file extensions.
  • Updated the project’s package.json to set "type": "module".
  • Updated the year in the copyright header for all modified files.

What are the acceptance criteria?

  • No remaining extensionless imports.
  • ESLint configuration correctly enforces file extensions.
  • Copyright headers are updated.

Feedback:
Please review and let me know if any further adjustments are required. Thank you!

@MattIPv4
Copy link
Contributor

MattIPv4 commented Oct 2, 2024

👋 Just as an FYI for the future, you don't need to create a new PR to make changes to it, you should just push to your existing PR. cc #485

@MattIPv4 MattIPv4 mentioned this pull request Oct 2, 2024
Closed
@MattIPv4 MattIPv4 changed the title "Fix #454: Enforce file extensions in imports, remove ESM usages, update copyright headers" Enforce file extensions in imports to comply with ESM standards Oct 2, 2024
MattIPv4
MattIPv4 reviewed Oct 2, 2024
View reviewed changes
package.json Show resolved Hide resolved
src/nginxconfig/i18n/en/templates/domain_sections/https.js Outdated Show resolved Hide resolved
src/nginxconfig/i18n/ru/index.js Outdated Show resolved Hide resolved
src/nginxconfig/i18n/ru/templates/domain_sections/logging.js Outdated Show resolved Hide resolved
src/nginxconfig/util/analytics.js Outdated Show resolved Hide resolved
src/nginxconfig/util/browser_language.js Outdated Show resolved Hide resolved
src/nginxconfig/util/computed_from_defaults.js Outdated Show resolved Hide resolved
src/nginxconfig/util/import_data.js Outdated Show resolved Hide resolved
src/nginxconfig/util/logging.js Outdated Show resolved Hide resolved
vue.config.js Outdated Show resolved Hide resolved
@dmz-v-x
Copy link
Contributor Author

dmz-v-x commented Oct 3, 2024

👋 I've made the requested changes regarding the copyright headers and reverted unnecessary modifications. Please review when you have a chance. Thank you!

MattIPv4
MattIPv4 reviewed Oct 3, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
MattIPv4
MattIPv4 reviewed Oct 3, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
MattIPv4
MattIPv4 reviewed Oct 3, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
MattIPv4
MattIPv4 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm for all the work on this

@MattIPv4 MattIPv4 merged commit b893df3 into digitalocean:master Oct 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use proper ESM imports w/ extensions
2 participants
@dmz-v-x @MattIPv4