config: cleanup, add env var support #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anitgandhi
force-pushed
the
agandhi/config-updates
branch
2 times, most recently
from
67aa70d to
b222ecc
Compare
CLI flags are still respected. Env vars will be prefixed with DROPLET_AGENT_ ; for example, DROPLET_AGENT_DEBUG maps to the --debug CLI flag. This makes it easier to drive config with systemd drop-in files with the `Environment=` directive, for example.
anitgandhi
force-pushed
the
agandhi/config-updates
branch
from
b222ecc to
e2b3694
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Please review each commit separately to make it easier. There are details in some of the extended commit messages.
This some cleanup in preparation of future work that I'd like to have behind a configuration variable to gate the behavior.