Add support for loadbalancer services in managed-firewall #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrantz01
added a commit
to akrantz01/terraform-k8s-gitops
that referenced
this pull request
Feb 13, 2023
This is a band-aid fix over the underlying issues where the DigitalOcean CCM-managed firewall can only open allow traffic for NodePort services. Once digitalocean/digitalocean-cloud-controller-manager#588 is merged, this can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for allowing
type: LoadBalancerservices to be added to the CCM-managed firewall.If a load balancer has not been attached to the service or the service has
allocateLoadBalancerNodePortsis set tofalse, no firewall rule is added.