Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use APP_ID instead of the non-existing APP_NAME #152

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

eyalch
Copy link
Contributor

@eyalch eyalch commented Oct 7, 2024

Looks like the action is referencing a non-existing app-wide variable named APP_NAME.

Reading the app-wide variables section in the docs, the available app-wide variables are:

  • APP_DOMAIN
  • APP_URL
  • APP_ID

Since the action correctly references APP_DOMAIN and APP_URL, and since there's no reference to APP_NAME anywhere in the docs, I'm assuming a typo resulted in APP_NAME instead of APP_ID.

In addition to the fix, I added a test that makes sure that all the supported app-wide variables are handled correctly.

Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks a lot!

Let me know if you want to adjust the test as proposed. If not, we can merge as-is as well.

utils/env_test.go Show resolved Hide resolved
@markusthoemmes markusthoemmes added the bug Something isn't working label Oct 8, 2024
@markusthoemmes markusthoemmes merged commit 6464f32 into digitalocean:main Oct 8, 2024
3 checks passed
@markusthoemmes
Copy link
Contributor

This is part of v2.0.5. Thanks for the contribution @eyalch!

@eyalch eyalch deleted the fix-app-id-variable branch October 8, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants