Extract PR number from event instead of using RefName #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusthoemmes
force-pushed
the
better-pr-number-extraction
branch
from
934164b to
1ed88ab
Compare
On normal pull-request events, the `RefName` attribute is usually `$prNumber/merge`. However, when **merging** a pull-request, it becomes the name of the branch the PR is merged into. This beraks the connection between creating and deleting preview apps. This changes the method of figuring out the underlying pull-request by looking at the event payload directly and parsing the respective number out of there.
markusthoemmes
force-pushed
the
better-pr-number-extraction
branch
from
1ed88ab to
bd8fefb
Compare
spinits4
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On normal pull-request events, the
RefNameattribute is usually$prNumber/merge. However, when merging a pull-request, it becomes the name of the branch the PR is merged into. This beraks the connection between creating and deleting preview apps.This changes the method of figuring out the underlying pull-request by looking at the event payload directly and parsing the respective number out of there.