Cartographer and PixPlot Image preview #400

dale-wahl · 2023-11-30T11:30:10Z

This is merge-able!

Cartographer processor developed and functional; it allows, in principle, the creation of manifests (coordinate maps) that can be read and displayed by PixPlot. For the moment, I have it set to create a default grid mapping, but it should be easy to expand and add to if we would like to design different mappings.
This basic grid mapping is now done automatically (via preset) on downloading images. It then is used as a preview allowing users to easily explore their downloaded images!
I took and modified the PixPlot template and incorporated it into 4CAT. Primarily this means that it does not create a new static site (as PixPlot was designed) and instead loads them with our data (e.g., it uses the already downloaded images and templates instead of new hard-coded HTML files).

Notes:

The @app.route('/result/<path:query_file>') now can also load archived files. ~~This may not be the best design and we might perhaps not archive the images since they have this new use. Recommend reviewing this part.~~ Updated to open files and generate response on the fly.

To-do:

Cartographer options can be expanded and make it a bit easier to integrate new mappings.
~~I have done some basic editing to the PixPlot template, but it could benefit from more work.~~ More editing done for 4CAT specific plots!
Particularly making certain features optional such as the "Hotspots" and some of the icons both of which are not used by default.
~~Add metadata to the Image descriptions~~
~~Move the image description panel to one of the sides; it works where it is with the image filename only, but is not great/intuitive with further descriptions~~
edit add presets for tiktok and telegram image downloaders

…dataset results folder it's working on pixplot datasets and the new cartagrapher datasets by using there manifests and data subfolder!

idea being we can have a configurable cartographer and run default "image wall" settings

Still do not know why but nothing renders; even the atlas images!

…ing them)

stijn-uva

Some crashes I found when testing.

stijn-uva · 2024-02-20T16:14:15Z

webtool/views/views_dataset.py

@@ -24,6 +27,21 @@

 csv.field_size_limit(1024 * 1024 * 1024)

+if app.logger.getEffectiveLevel() == 10:


Does this still need to be here? It crashes (since time is not imported)

stijn-uva · 2024-02-20T16:16:23Z

webtool/views/views_dataset.py

@@ -401,10 +479,12 @@ def show_result(key):
    :param key:  Result key
    :return:  Rendered template
    """
+    ds_start = time.time()


stijn-uva · 2024-02-20T16:17:59Z

webtool/views/views_dataset.py

+            # TODO: Better way to identify this edge case?
+            elif child.type.startswith("image-downloader"):
+                # Images were downloaded from this zip; this is the case for presets
+                for grandkid in child.get_children(instaniate_datasets=True):


TypeError: get_children() got an unexpected keyword argument 'instaniate_datasets'

stijn-uva · 2024-02-20T16:26:04Z

Also, it would be nice to make this compatible with all image-generating/downloading processors, including 'Extract video frames'.

cartographer does not understand the folder structure

dale-wahl · 2024-02-21T09:50:31Z

Also, it would be nice to make this compatible with all image-generating/downloading processors, including 'Extract video frames'.

Right now, I need the cartographer to understand what to do with subfolders of image groupings. Or perhaps iterate_archive_contents doesn't since the files are not found (possibly a mismatch between the temp_path yielded and where the file was actually extracted). I could unpack and os.walk in the cartographer, but I really hate that message as it does not work well with amount caps since the whole (often quite large) archive is unpacked anyway.

Regardless, I think we could do better than to just splash the images semi in order. They could be automatically categorized by the subfolders they are in for example (mimicking the scene timeline).

.metadata.json with directories currently expects filename only (not subdirs), but this could be changed.

dale-wahl · 2024-02-21T12:19:42Z

Also, it would be nice to make this compatible with all image-generating/downloading processors, including 'Extract video frames'.

Right now, I need the cartographer to understand what to do with subfolders of image groupings. Or perhaps iterate_archive_contents doesn't since the files are not found (possibly a mismatch between the temp_path yielded and where the file was actually extracted). I could unpack and os.walk in the cartographer, but I really hate that message as it does not work well with amount caps since the whole (often quite large) archive is unpacked anyway.

Regardless, I think we could do better than to just splash the images semi in order. They could be automatically categorized by the subfolders they are in for example (mimicking the scene timeline).

Sorted out subfolder handling in cartographer. Works with the video-frames processor. Currently there is no usable .metadata.json file (looks to be copied over from higher level processor and does not have image filename references for post_ids to be extracted) so images have no descriptions. I did not do anything to categorize the images by scene. That's more complex as the categories are currently decided from the metadata (which does not exist). This would be a special case.

…Processor.display_in_ui() Allow using `display_in_ui` to hide processors from UI but allow them to be queued either via API or presets. This avoids issue of is_compatible_with() having to be used to hide processors with sometimes ill effects.

…is_compatible_with

cannot just check plot since preview also checks child datasets of zips for plots

dale-wahl · 2024-05-28T11:00:36Z

I merged master into cartographer again. Last week there were a few bugs. This week the only thing I saw was actually an issue with the master in that, if we allow unlimited images (e.g., max images is set to 0 in configuration), all the downloaders would use a max of 0 and thus always download all images!

There is this one super weird but and so far only visible on tiktok datasets...

I am not sure what's going on there, but it is only the thumbnails so I need to figure out why that is the case.

dale-wahl · 2024-05-28T12:09:45Z

I merged master into cartographer again. Last week there were a few bugs. This week the only thing I saw was actually an issue with the master in that, if we allow unlimited images (e.g., max images is set to 0 in configuration), all the downloaders would use a max of 0 and thus always download all images!

There is this one super weird but and so far only visible on tiktok datasets... I am not sure what's going on there, but it is only the thumbnails so I need to figure out why that is the case.

ok, ok. it actually just occurs when there are very few images. PixPlot itself fails if you have less than 12 (and our cartagrapher ignores/bypasses that). it seems to have to do with the zoom not being far enough away that it doesn't trigger the thumbnails. no idea how to fix or address... but yeah.

finally figured this out!

sal-uva · 2024-09-11T16:29:02Z

Tried to run this, but getting some importing errors in JS:

sal-uva · 2024-09-11T16:35:29Z

I would also suggest to rename the processor to something more specific. "Create Image visualisation" is a bit general; something like "Display images on Web page" is already a bit more concrete.

Relatedly, it is a bit unclear to me what can I do with the outputted zip file. Can the description be updated so users are told what they can do with it? And maybe add a readme file in the zip results?

As I understand it, the page opened by the "View" button is what's most interesting here right? Can't the zip file contain this page as well?

Otherwise good work!!

dale-wahl added 24 commits October 24, 2023 15:38

basic mappings for a pixplot; known bug

4f0748e

Merge branch 'master' into cartagrapher

9ca73e0

add in LOTS of necessary steps so it actually works

cae91bc

add the pixplot template as a base

6f62b13

fix up atlas overlapping images & increase res

d473454

create a "plots" endpoint that uses pixplot_template and theoretical …

7177441

…dataset results folder it's working on pixplot datasets and the new cartagrapher datasets by using there manifests and data subfolder!

fix up some path issues in the js file

8c38621

add plot as preview!

4459394

rename

c0a042e

Update .gitignore

97bd8c3

Update .gitignore

946a167

add pixplot_template images

0ae3382

Update .gitignore

372d1ac

add additional images for pixplot

fad263d

build paths based on two different sources (assets and data)

c01c6f4

Merge branch 'master' into cartographer

3c8256e

Merge branch 'master' into cartographer

2cbda77

create preset that auto runs cartographer

3e47291

idea being we can have a configurable cartographer and run default "image wall" settings

only run preset image downloader

dfae9d9

remove debug log

9ea862c

serve archived files

701a480

serve archived files via frontend; use those images in cartographer

1ce0caf

fix umap thumbsize when actually grid

d1184b9

fix up the cartographer page a bit

64e5a2c

dale-wahl requested a review from stijn-uva November 30, 2023 11:31

dale-wahl added 5 commits November 30, 2023 17:11

Merge branch 'master' into cartographer

1ca28a2

do NOT change that 128 thumbnail size

e1fd2bf

Still do not know why but nothing renders; even the atlas images!

serve archive files via generator (as opposed to extracting and delet…

067506b

…ing them)

fix adding annotation labels to mapped results

c4ad487

preview accepts url params to increase number/size of preview

7ae8315

dale-wahl added 2 commits February 20, 2024 17:15

Merge branch 'master' into cartographer

c25f8ec

remove dataset.get

14fe1f0

stijn-uva reviewed Feb 20, 2024

View reviewed changes

dale-wahl added 5 commits February 20, 2024 18:34

fix typo and remove time_this debug

4d62dcf

revert .env change (mistake)

5d16065

add cartographer for video scenes

8970f64

Merge branch 'master' into cartographer

cb370e6

deactivate video_scene_frames to plot pipeline

a04ee29

cartographer does not understand the folder structure

dale-wahl added 2 commits February 21, 2024 13:15

cartographer handle directories

b5ee46b

.metadata.json with directories currently expects filename only (not subdirs), but this could be changed.

reenable video-scene-frames preset to plot

e053fee

dale-wahl added 11 commits February 21, 2024 15:00

remove video-scene-frames preset; breaks other preset's is_compatible

5685d31

Merge branch 'display_in_ui' into cartographer

77fa3d3

update image downloaders and presets to use display_in_ui instead of …

9743254

…is_compatible_with

don't delete twice

1b6c0c8

preview zip files opens new window as opposed to iframe

7720631

cannot just check plot since preview also checks child datasets of zips for plots

Merge branch 'master' into cartographer

7f68486

fix up ui display changes

cb477c9

fix is_hidden from tiktok video to image downloader

c6bdc04

Merge branch 'master' into cartographer

219f30b

fix up max images (if 0, max would always use 0)

ad79e70

dale-wahl added 2 commits May 28, 2024 15:12

map umap optional!

8bcc5b1

finally figured this out!

alphabetic is also optional

35c1c6d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cartographer and PixPlot Image preview #400

Cartographer and PixPlot Image preview #400

dale-wahl commented Nov 30, 2023 •

edited

Loading

stijn-uva left a comment

stijn-uva Feb 20, 2024

stijn-uva Feb 20, 2024

stijn-uva Feb 20, 2024

stijn-uva commented Feb 20, 2024

dale-wahl commented Feb 21, 2024

dale-wahl commented Feb 21, 2024

dale-wahl commented May 28, 2024

dale-wahl commented May 28, 2024 •

edited

Loading

sal-uva commented Sep 11, 2024

sal-uva commented Sep 11, 2024

		@@ -24,6 +27,21 @@

		csv.field_size_limit(1024 * 1024 * 1024)

		if app.logger.getEffectiveLevel() == 10:

Cartographer and PixPlot Image preview #400

Are you sure you want to change the base?

Cartographer and PixPlot Image preview #400

Conversation

dale-wahl commented Nov 30, 2023 • edited Loading

stijn-uva left a comment

Choose a reason for hiding this comment

stijn-uva Feb 20, 2024

Choose a reason for hiding this comment

stijn-uva Feb 20, 2024

Choose a reason for hiding this comment

stijn-uva Feb 20, 2024

Choose a reason for hiding this comment

stijn-uva commented Feb 20, 2024

dale-wahl commented Feb 21, 2024

dale-wahl commented Feb 21, 2024

dale-wahl commented May 28, 2024

dale-wahl commented May 28, 2024 • edited Loading

sal-uva commented Sep 11, 2024

sal-uva commented Sep 11, 2024

dale-wahl commented Nov 30, 2023 •

edited

Loading

dale-wahl commented May 28, 2024 •

edited

Loading