1430: Show extend card notification only if the card is valid #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seluianova
requested review from
steffenkleinle,
f1sh1918 and
ztefanie
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Just noticed a small issue:
After a user extends the card and activates the new one, the extend card notification is still displayed for the old (revoked) card, and this can be confusing.
Proposed changes
Change the condition to display the notification: if the card is valid (instead of not expired) and extendable
Side effects
Couldn’t think of any
Testing
If needed, please refer to the detailed testing instructions from here:
#1772
Once the extendable card has been created:
Resolved issues
Follow up for #1430