Improve development setup docs #1807
Conversation
steffenkleinle
requested review from
f1sh1918,
ztefanie and
seluianova
as code owners
| The command has to be run every time a device is connected. | ||
|
|
||
| ```shell | ||
| adb reverse tcp:8081 tcp:8081 && adb reverse tcp:8000 tcp:8000 && adb reverse tcp:5002 tcp:5002 |
There was a problem hiding this comment.
This includes port forwarding for integreat as I figured having one command in the history for this makes sense. However, I am also open to keep it entitlementcard only.
There was a problem hiding this comment.
hm we have the expose:ports that can be triggered via npm run expose:ports i think you should even update this (it also checks for attached devices) and add the command here
steffenkleinle
force-pushed
the
development-setup
branch
from
9bd2ca6
to
1f2db62
Compare
| @@ -1,4 +1,3 @@ | |||
| version: "3.5" | |||
There was a problem hiding this comment.
This is obsolete and led to a warning on startup.
See https://docs.docker.com/reference/compose-file/version-and-name/.
steffenkleinle
changed the title
steffenkleinle
force-pushed
the
development-setup
branch
from
1f2db62
to
e19ff17
Compare
| The command has to be run every time a device is connected. | ||
|
|
||
| ```shell | ||
| adb reverse tcp:8081 tcp:8081 && adb reverse tcp:8000 tcp:8000 && adb reverse tcp:5002 tcp:5002 |
There was a problem hiding this comment.
hm we have the expose:ports that can be triggered via npm run expose:ports i think you should even update this (it also checks for attached devices) and add the command here
Short description
I cleaned up the development setup with new best practices.
Proposed changes
Side effects
Testing
None.
Resolved issues
Fixes: None.