Bump nodes version to 18 & 20 in ci. #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSAssassin
approved these changes
Nov 28, 2023
dlongley
approved these changes
Nov 28, 2023
.github/workflows/main.yml
Outdated
| @@ -24,7 +24,7 @@ jobs: | |||
| timeout-minutes: 10 | |||
| strategy: | |||
| matrix: | |||
| node-version: [14.x, 16.x, 18.x] | |||
| node-version: [16.x, 18.x, 20.x] | |||
There was a problem hiding this comment.
I'm happy to just test 18.x since 16.x is EOL.
There was a problem hiding this comment.
set most tests to 18 and dropped 16 here: 4db7ff1
|
@aljones15 README needs to be updated too. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
- Coverage 87.27% 87.05% -0.22%
==========================================
Files 4 4
Lines 770 811 +41
==========================================
+ Hits 672 706 +34
- Misses 98 105 +7
Continue to review full report in Codecov by Sentry.
|
README updated there |
JSAssassin
changed the title
|
closing in favor of: #164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.