Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weekday value object #55

Merged
merged 22 commits into from
Jun 9, 2024
Merged

Add weekday value object #55

merged 22 commits into from
Jun 9, 2024

Conversation

christian-kolb
Copy link
Contributor

@christian-kolb christian-kolb commented Jun 9, 2024

Changes

  • New value object.
  • New Doctrine type.
  • New normalizer.

@christian-kolb christian-kolb self-assigned this Jun 9, 2024
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 78.15126% with 26 lines in your changes missing coverage. Please review.

Project coverage is 96.79%. Comparing base (653a356) to head (30f19b1).
Report is 3 commits behind head on main.

Current head 30f19b1 differs from pull request most recent head bb7c663

Please upload reports for the commit bb7c663 to get more accurate results.

Files Patch % Lines
src/Weekdays.php 0.00% 16 Missing ⚠️
src/Serializer/WeekdaysNormalizer.php 0.00% 10 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##                main      #55      +/-   ##
=============================================
- Coverage     100.00%   96.79%   -3.21%     
- Complexity       217      263      +46     
=============================================
  Files             16       24       +8     
  Lines            680      810     +130     
=============================================
+ Hits             680      784     +104     
- Misses             0       26      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christian-kolb christian-kolb merged commit 0df267f into main Jun 9, 2024
4 checks passed
@christian-kolb christian-kolb deleted the add-weekday-value-object branch June 9, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant