Refactor moment

src/Doctrine/MomentType.php

@@ -5,20 +5,26 @@
 namespace DigitalCraftsman\DateTimePrecision\Doctrine;
 
 use DigitalCraftsman\DateTimePrecision\Moment;
+use DigitalCraftsman\SelfAwareNormalizers\Doctrine\StringNormalizableType;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Platforms\MySQLPlatform;
 use Doctrine\DBAL\Platforms\PostgreSQLPlatform;
-use Doctrine\DBAL\Types\Type;
 
-final class MomentType extends Type
+/**
+ * @codeCoverageIgnore
+ */
+final class MomentType extends StringNormalizableType
 {
-    /** @codeCoverageIgnore */
-    public function getName(): string
+    public static function getTypeName(): string
     {
         return 'dtp_moment';
     }
 
-    /** @codeCoverageIgnore */
+    public static function getClass(): string
+    {
+        return Moment::class;
+    }
+
     public function getSQLDeclaration(array $column, AbstractPlatform $platform): string
     {
         if ($platform instanceof PostgreSQLPlatform) {
@@ -31,28 +37,4 @@ public function getSQLDeclaration(array $column, AbstractPlatform $platform): st
 
         throw new \RuntimeException('Unsupported platform');
     }
-
-    /** @param Moment|null $value */
-    public function convertToDatabaseValue($value, AbstractPlatform $platform): ?string
-    {
-        if ($value === null) {
-            return null;
-        }
-
-        return $value->format('Y-m-d H:i:s.u');
-    }
-
-    /** @param string|null $value */
-    public function convertToPHPValue($value, AbstractPlatform $platform): ?Moment
-    {
-        return $value === null
-            ? null
-            : Moment::fromString($value);
-    }
-
-    /** @codeCoverageIgnore */
-    public function requiresSQLCommentHint(AbstractPlatform $platform): bool
-    {
-        return true;
-    }
 }

src/Moment.php

@@ -4,9 +4,11 @@
 
 namespace DigitalCraftsman\DateTimePrecision;
 
-final readonly class Moment implements \Stringable
+use DigitalCraftsman\SelfAwareNormalizers\Serializer\StringNormalizable;
+
+final readonly class Moment implements \Stringable, StringNormalizable
 {
-    private const DATE_TIME_FORMAT = \DateTimeInterface::ATOM;
+    private const string DATE_TIME_FORMAT_INCLUDING_MILLISECONDS = 'Y-m-d H:i:s.u';
 
     // -- Construction
 
@@ -39,7 +41,19 @@ public static function fromDateTime(\DateTimeImmutable $dateTime): self
 
     public function __toString(): string
     {
-        return $this->format(self::DATE_TIME_FORMAT);
+        return $this->format(self::DATE_TIME_FORMAT_INCLUDING_MILLISECONDS);
+    }
+
+    // -- String normalizable
+
+    public static function denormalize(string $data): self
+    {
+        return new self(new \DateTimeImmutable($data, new \DateTimeZone('UTC')));
+    }
+
+    public function normalize(): string
+    {
+        return $this->format(self::DATE_TIME_FORMAT_INCLUDING_MILLISECONDS);
     }
 
     // -- Accessors

src/Resources/config/services.yaml

@@ -7,9 +7,6 @@ services:
     class: DigitalCraftsman\DateTimePrecision\Clock\SystemClock
 
   # Normalizers
-  DigitalCraftsman\DateTimePrecision\Serializer\MomentNormalizer:
-    tags: [ { name: 'serializer.normalizer' } ]
-
   DigitalCraftsman\DateTimePrecision\Serializer\TimeNormalizer:
     tags: [ { name: 'serializer.normalizer' } ]
 

tests/Moment/NormalizeDenormalizeTest.php

@@ -0,0 +1,35 @@
+<?php
+
+declare(strict_types=1);
+
+namespace DigitalCraftsman\DateTimePrecision\Moment;
+
+use DigitalCraftsman\DateTimePrecision\Moment;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @coversDefaultClass \DigitalCraftsman\DateTimePrecision\Moment
+ */
+final class NormalizeDenormalizeTest extends TestCase
+{
+    /**
+     * @test
+     *
+     * @covers ::normalize
+     * @covers ::denormalize
+     */
+    public function normalize_and_denormalize_works(): void
+    {
+        // -- Arrange
+        $moment = Moment::fromString('2022-10-08 15:30:00.123456');
+        $data = '2022-10-08 15:30:00.123456';
+
+        // -- Act
+        $normalized = $moment->normalize();
+        $denormalized = Moment::denormalize($data);
+
+        // -- Assert
+        self::assertSame($data, $normalized);
+        self::assertEquals($moment, $denormalized);
+    }
+}