ebmc: transition_systemt does not need optional transt #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
trans_expr_not_optional
branch
from
eea030a to
3f76670
Compare
tautschnig
approved these changes
Dec 11, 2023
src/ebmc/transition_system.h
Outdated
Comment on lines
22
to
25
| transition_systemt() | ||
| : trans_expr{ | ||
| ID_trans, | ||
| conjunction({}), | ||
| conjunction({}), | ||
| conjunction({}), | ||
| typet()} | ||
| { | ||
| } |
There was a problem hiding this comment.
- Is there some place where this should now be used?
- I am on the fence whether the empty conjunction is helpful here or not: it makes clear that these operands should eventually hold conjunctions, but does hide that this is just a fancy way of producing
true_exprt.
There was a problem hiding this comment.
Replaced by true_exprt()
kroening
force-pushed
the
trans_expr_not_optional
branch
from
3f76670 to
217fac4
Compare
The trans_expr in transition_systemt is always populated, and does not need to be optional.
kroening
force-pushed
the
trans_expr_not_optional
branch
from
217fac4 to
e4fa47b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
trans_exprintransition_systemtis always populated, and does not need to be optional.