Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cmake for cleaning in cmake job #8547

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Use cmake for cleaning in cmake job #8547

wants to merge 5 commits into from

Conversation

peterschrammel
Copy link
Member

@peterschrammel peterschrammel commented Dec 30, 2024 •
edited
Loading

instead of make

Based on #8487

  • Each commit message has a non-empty body, explaining why the change was made.
  • [n/a] Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • [n/a] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • [n/a] Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [n/a] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • [n/a] White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@peterschrammel
Use Maven to compile all regression test sources upfront (CMake)
db2f7b5 
This commit adds the CMake integration to call Maven
to compile the test sources.
@peterschrammel
Use Maven to compile all regression test sources upfront (Make)
d878b5d 
This commit adds the Make integration to call Maven
to compile the test sources.
@peterschrammel
Compile jbmc/ArithmeticException1 test sources
e6e8fbf 
Add pom.xml for compilation,
move sources
remove obsolete pre-compiled class file.
@peterschrammel
Compile jbmc/classpath-jar-load-whole-jar test sources
3de45e9 
Fix pom.xml for compilation,
remove obsolete pre-compiled jar file.
@peterschrammel
Use cmake for cleaning in cmake job
fc8cfc2 
which makes more sense than building with cmake
and cleaning with make.
@codecov Codecov
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.93%. Comparing base (f9a7807) to head (fc8cfc2).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8547      +/-   ##
===========================================
+ Coverage    78.38%   78.93%   +0.54%     
===========================================
  Files         1729     1729              
  Lines       200151   198757    -1394     
  Branches     18244    18313      +69     
===========================================
  Hits        156883   156883              
+ Misses       43268    41874    -1394

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig will be requested when the pull request is marked ready for review tautschnig is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependent - do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peterschrammel