-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CBMC version 6 release process changes #7987
Changes from all commits
5b1c0ff
2d14e99
b2925f3
821d58c
b580d85
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,8 +40,8 @@ endif() | |
# filenames) | ||
file( | ||
STRINGS src/config.inc CBMC_VERSION | ||
REGEX "CBMC_VERSION = (.*)") | ||
string(REGEX REPLACE "CBMC_VERSION = (.*)" "\\1" CBMC_VERSION ${CBMC_VERSION}) | ||
REGEX "CBMC_VERSION = ([0-9.]+).*") | ||
string(REGEX REPLACE "CBMC_VERSION = ([0-9.]+).*" "\\1" CBMC_VERSION ${CBMC_VERSION}) | ||
Comment on lines
+43
to
+44
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This section is to avoid a problem with CMake. Essentially CMake accepts version of type Before we were passing anything specified in In this way we are just passing the part of the version that is composed of digits and |
||
message(STATUS "Building CBMC version ${CBMC_VERSION}") | ||
|
||
project(CBMC VERSION ${CBMC_VERSION}) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# Temporary changes for v6 | ||
|
||
This is a temporary file, containing changes done to release process for v6, | ||
that need to be reverted back. | ||
|
||
It's a file in the repository to allow for easier tracking of the status | ||
of things among the broader community, and to allow everyone to add/delete | ||
things they believe should be in here. | ||
|
||
The file is scheduled for deletion by the actual release of `v6` and subsequent | ||
rollback of the changes. | ||
|
||
## Stack | ||
|
||
* Revert changes to homebrew PR push (`.github/workflows/release-packages.yaml`) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Commit hashes could be really handy here, assuming that we can avoid invalidating them in a re-base before the PR is merged. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure if we need commit hashes here - this was supposed to be a casual thing just to verify our reverted changes against the log here, sort of a double-entry bookkeeping practice but for the purpose of managing the process. But if keen, I can also add this in a new PR. |
||
* Revert changes to docker image push (`.github/workflows/releas-packages.yaml`) | ||
* Remove marking of release as `prerelease` (`.github/workflows/regular-release.yaml`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛏️ It might be good to put a short comment on each of these disabled sections to explain why it is disabled. It is possible that someone might see that they are not receiving new versions from Docker / homebrew and go looking here. So some comments could save some confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will consider this for a next PR, but I want to move this one forward to unblock us.
In the meantime, I'm hoping that someone coming across this change would see the
blame
long which would lead him to the commit 2d14e99 and its message that explains the situation.