-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CBMC version 6 release process changes #7987
Merged
NlightNFotis
merged 5 commits into
diffblue:develop
from
NlightNFotis:v6_release_process
Nov 13, 2023
+82
−64
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5b1c0ff
Mark new releases as prerelease
NlightNFotis 2d14e99
Temporarily deactivate homebrew PR and docker image push.
NlightNFotis b2925f3
Mark version 6.0.0 preview of CBMC
NlightNFotis 821d58c
Change version string handling to ignore suffixes in CMakeLists.txt
NlightNFotis b580d85
Add scratch file for a v6 release process undo stack
NlightNFotis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# Temporary changes for v6 | ||
|
||
This is a temporary file, containing changes done to release process for v6, | ||
that need to be reverted back. | ||
|
||
It's a file in the repository to allow for easier tracking of the status | ||
of things among the broader community, and to allow everyone to add/delete | ||
things they believe should be in here. | ||
|
||
The file is scheduled for deletion by the actual release of `v6` and subsequent | ||
rollback of the changes. | ||
|
||
## Stack | ||
|
||
* Revert changes to homebrew PR push (`.github/workflows/release-packages.yaml`) | ||
* Revert changes to docker image push (`.github/workflows/releas-packages.yaml`) | ||
* Remove marking of release as `prerelease` (`.github/workflows/regular-release.yaml`) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit hashes could be really handy here, assuming that we can avoid invalidating them in a re-base before the PR is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we need commit hashes here - this was supposed to be a casual thing just to verify our reverted changes against the log here, sort of a double-entry bookkeeping practice but for the purpose of managing the process.
But if keen, I can also add this in a new PR.