Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appropriate names to steps of code QL CI jobs #7967

Merged

Conversation

thomasspriggs
Copy link
Collaborator

This PR adds appropriate names to steps of code QL CI jobs. When the name is not specified, the github UI uses the name of the first command as the step name. This was misleading as it resulted in a 48 minute step titled "Run sudo apt-get update" which was also doing the build commands.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

When the `name` is not specified, the github UI uses the name of the
first command as the step. This was misleading as it resulted in a 48
minute step titled "Run sudo apt-get update" which was also doing the
build commands.
@thomasspriggs thomasspriggs requested a review from a team as a code owner October 18, 2023 16:53
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3535b61) 79.11% compared to head (21ca56c) 79.03%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7967      +/-   ##
===========================================
- Coverage    79.11%   79.03%   -0.08%     
===========================================
  Files         1701     1701              
  Lines       196271   196271              
===========================================
- Hits        155280   155123     -157     
- Misses       40991    41148     +157     

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasspriggs thomasspriggs merged commit 2bab0b3 into diffblue:develop Oct 19, 2023
35 of 36 checks passed
@thomasspriggs thomasspriggs deleted the tas/name_code_ql_steps branch October 19, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants