Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for union member expressions in incremental smt2 decision procedure #7961

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

thomasspriggs
Copy link
Collaborator

This PR adds support for union member expressions in incremental smt2 decision procedure. This support is sufficient for some of the existing union regression tests to pass.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a531056) 78.75% compared to head (5985e55) 78.83%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7961      +/-   ##
===========================================
+ Coverage    78.75%   78.83%   +0.08%     
===========================================
  Files         1701     1701              
  Lines       196224   196246      +22     
===========================================
+ Hits        154540   154719     +179     
+ Misses       41684    41527     -157     
Files Coverage Δ
...vers/smt2_incremental/encoding/struct_encoding.cpp 96.85% <100.00%> (+0.07%) ⬆️
...vers/smt2_incremental/encoding/struct_encoding.cpp 100.00% <100.00%> (ø)

... and 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasspriggs thomasspriggs marked this pull request as ready for review October 16, 2023 09:11
@thomasspriggs thomasspriggs merged commit 05ccb75 into diffblue:develop Oct 16, 2023
36 checks passed
@thomasspriggs thomasspriggs deleted the tas/smt_union_member branch October 16, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants