Output dependency metrics in json format #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasifimtiazohi
requested review from
bmwill and
xvschneider
and removed request for
xvschneider and
bmwill
nasifimtiazohi
force-pushed
the
json
branch
3 times, most recently
from
ef3def9 to
4a5ab35
Compare
bmwill
reviewed
Jul 29, 2021
depdive/src/lib.rs
Outdated
| Self::get_dep_pacakge_metrics(&graph, only_direct) | ||
| } | ||
|
|
||
| fn get_dep_pacakge_metrics(graph: &PackageGraph, only_direct: bool) -> Result<String> { |
There was a problem hiding this comment.
might want to name this fn in such a way that indicates it outputs Json
depdive/src/lib.rs
Outdated
| Self::get_code_metrics(&graph, only_direct) | ||
| } | ||
|
|
||
| fn get_code_metrics(graph: &PackageGraph, only_direct: bool) -> Result<String> { |
| @@ -8,7 +8,6 @@ edition = "2018" | |||
|
|
|||
| [dependencies] | |||
| anyhow = "1.0.38" # error handling library | |||
| tabled = "0.2.1" | |||
There was a problem hiding this comment.
Whats the rationale for wanting to remove this?
There was a problem hiding this comment.
rationale is - There are too many fields for a pretty tabled output which is no better than just json output. In midpoint demo, I just chose a subset of the fields so that doesn't break in the monitor screen but that ain't a feature. I think we can make it a future work on how to present a higher-level abstraction of these data based on idea here. #103
bmwill
previously approved these changes
Jul 29, 2021
bmwill
previously approved these changes
Jul 30, 2021
|
/land |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.